Issue #3458767: Replace node grants for "public" and "community" visibilities #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this Pull Request! To ensure Pull Requests are easy to find and understand for all our team-members we've established some standardised rules. While reviewing this pull request I've found the following issues, please resolve them. Missing milestone 🤖 This is an automatically produced message by the Open Social PR manager. |
nechai
force-pushed
the
feature/replace-node-grants-visibilities
branch
3 times, most recently
from
374c034 to
7e09375
Compare
nechai
added
type: refactoring
nechai
force-pushed
the
feature/replace-node-grants-visibilities
branch
from
7e09375 to
1e1f77c
Compare
nechai
force-pushed
the
feature/3458767-replace-node-grants
branch
from
3b2a0de to
b52e1bb
Compare
nechai
force-pushed
the
feature/replace-node-grants-visibilities
branch
from
1e1f77c to
edf0079
Compare
nechai
force-pushed
the
feature/3458767-replace-node-grants
branch
from
ec9b509 to
a882e33
Compare
nechai
force-pushed
the
feature/replace-node-grants-visibilities
branch
from
edf0079 to
b9402af
Compare
ribel
changed the title
ribel
changed the title
ribel
added
status: needs review
ribel
approved these changes
Dec 20, 2024
ribel
merged commit 2539e06
into
feature/3458767-replace-node-grants
176 of 197 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
PR should be merged in #3961
Note
This PR doesn't require behat tests passing. Tests should be checked in #3961
Replace
node grantswith query alters for nodes withpublicandcommunityvisibilities.More details about the reasons why we need this PR can be found at #4098