-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When generating the seed list, we need the grid for the bounds #1024
Conversation
Pull Request Test Coverage Report for Build ff3bd7f59Details
💛 - Coveralls |
6c3eef0
to
6d61072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yessss, that looks better! 🚀
6d61072
to
c765511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gdey thanks for digging into this! You found the problem, but I'm wondering if the default behavior is the opposite of what we want. Up until this bug surfaced the bounds was always expected to be in 4326. With this change we now require all the users to add --wgs84=true
when seeding. It seems we should default to wgs84. Thoughts?
If 4326 was the default then i agree we should swap it. |
After discussion we decided it would be better to provide a flag to state the SRID of the bounds.
|
ff3bd7f
to
b9dab62
Compare
* updated proj to v0.3.0 * update golang.org/x/net/html
Added the ability to specify the srid to use. It defaults to 4326. Our old system normalized the bounds to grid, this meant that people could provide a bounds without the associated srid as long as it was either 4326 or 3853. With the change over, we were defaulting to 3853. This was the wrong default. Chanced the default 4326, and added ability to specify the srid. We will check to see if the SRID is supported by proj. For now the only srid's that are supported are 4326 and 3853.
b9dab62
to
141b759
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Our old system normalized the bounds to grid, this meant that people could provide a bounds without the associated srid as long as it was either 4326 or 3853. With the change over, we were defaulting to 3853. Added option to allow for the grid to be 4326.