Enhance server hostName handling #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hostName func is used to dynamically determine the hostName value in various API endpoints. The previous logic favored the Host value of request URL, but this value is often not set (i.e. when not operating behind a proxy). The default handling has been changed to return the request Host value if the request URL Host is not set. closes #1022
ARolek
force-pushed
the
issue-1022-enahce-hostName-handling
branch
from
1091990 to
5c1fec9
Compare
ARolek
changed the title
Pull Request Test Coverage Report for Build 5c1fec939Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hostName func is used to dynamically determine the hostName value in various API endpoints. The previous logic favored the Host value of request URL, but this value is often not set (i.e. when not operating behind a proxy). The default handling has been changed to return the request Host value if the request URL Host is not set.
This PR also addresses the outstanding ui vulns.