Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get slippy tiles to work. #130

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Get slippy tiles to work. #130

merged 2 commits into from
Jul 29, 2024

Conversation

gdey
Copy link
Member

@gdey gdey commented Jul 22, 2024

Updated slippy tiles to work as it use to.

But kept the ability to have different SRID's.

@gdey gdey force-pushed the try_to_fix_slippy_tiles branch from c8419f0 to 1b94fbb Compare July 25, 2024 08:40
@gdey gdey marked this pull request as ready for review July 25, 2024 08:41
@gdey gdey requested a review from ARolek July 25, 2024 08:41
@gdey gdey self-assigned this Jul 25, 2024
@gdey gdey force-pushed the try_to_fix_slippy_tiles branch 2 times, most recently from 6ab5267 to 008ced6 Compare July 25, 2024 08:50
@gdey gdey changed the title wip Get slippy tiles to work. Jul 25, 2024
@gdey gdey force-pushed the try_to_fix_slippy_tiles branch from 008ced6 to 7f4e993 Compare July 25, 2024 17:01
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few comments / nits / questions inline. No show stoppers. Thanks for tackling this.

slippy/tile.go Outdated Show resolved Hide resolved
bbox.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
slippy/maths.go Show resolved Hide resolved
slippy/maths.go Outdated Show resolved Hide resolved
slippy/maths.go Outdated Show resolved Hide resolved
slippy/tile.go Show resolved Hide resolved
slippy/tile.go Show resolved Hide resolved
slippy/tile.go Show resolved Hide resolved
slippy/tile_grid.go Outdated Show resolved Hide resolved
@gdey
Copy link
Member Author

gdey commented Jul 25, 2024

fixes #129 as well.

@gdey
Copy link
Member Author

gdey commented Jul 26, 2024

I have not pushed this up yet. Since I'm working through Tegola, to make sure there aren't any small changes needed. Once I have tegola working. Then I'll re-request a review and push, and tag. Then I can pin tegola to this tagged version.

@gdey gdey requested a review from ARolek July 29, 2024 22:42
@gdey gdey force-pushed the try_to_fix_slippy_tiles branch from 06c93c1 to a37246d Compare July 29, 2024 23:01
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did leave a couple of nits inline, but they're not show stoppers.

cmd/main.go Outdated Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
@gdey gdey force-pushed the try_to_fix_slippy_tiles branch from a37246d to 5347578 Compare July 29, 2024 23:29
gdey added 2 commits July 29, 2024 16:37
Added PixelRatioForZoom function to replace

We had a badly named function called PixelsToNative
that did not do a conversion but returned a ratio.

Renamed and expanded to all any tile dimension.
@gdey gdey force-pushed the try_to_fix_slippy_tiles branch from 5347578 to 55e666d Compare July 29, 2024 23:38
@gdey gdey merged commit 55e666d into master Jul 29, 2024
@gdey gdey deleted the try_to_fix_slippy_tiles branch July 29, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants