Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slippy.RangeFamilyAt doesn't return self or parents #129

Open
jchamberlain opened this issue Oct 30, 2023 · 0 comments
Open

slippy.RangeFamilyAt doesn't return self or parents #129

jchamberlain opened this issue Oct 30, 2023 · 0 comments

Comments

@jchamberlain
Copy link

jchamberlain commented Oct 30, 2023

Problem

RangeFamilyAt was rewritten in PR #99 and its behavior fundamentally changed. Previously, it returned:

  1. The tile itself, plus
  2. If zoom is less than the tile's zoom, all tiles ancestors at the specified zoom,
  3. If zoom is greater than the tile's zoom, all tile's descendants at the specified zoom.

After PR #99 it returns only (3). In addition, floating point error introduced by FromNative and ToNative cause the function's output to be unpredictable and therefore difficult to test (see #127).

PR #99 commented out the failing test: d04b99a#diff-e7c11f2955e26a4cf0f286e7b5eb5da15c1e475bf3fb386ad134449680f31354R56

Solution

Unknown. I don't know the background of this function, but Tegola's tests expect it to function the old way, not the new way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant