feat: implement --forbidden-keys
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
changed the title
--forbidden-key--reserved-key
|
Hello, thank you for the PR, I like the idea! I noticed that you first named it |
tigrato
changed the title
--reserved-key--forbidden-key
|
@tmzane thanks. I reverted the feature to its original name |
This PR implements a linter rule to deny usages of certain keys as attributes to enforce that developers don't override reserved keys managed by custom handlers. Signed-off-by: Tiago Silva <[email protected]>
mattdowdell
reviewed
May 9, 2024
tmzane
requested changes
May 9, 2024
mattdowdell
reviewed
May 9, 2024
Co-authored-by: Matthew Dowdell <[email protected]>
|
I just remembered that |
tmzane
approved these changes
May 9, 2024
tmzane
changed the title
--forbidden-key--forbidden-keys
|
@tigrato thanks, this is a great feature to have! @mattdowdell as always, thanks for the review! |
|
Oh, and we should bump Go version in go.mod, because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a linter rule to deny usages of certain keys as attributes to enforce that developers don't override reserved keys managed by custom handlers.