-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement -context-only=scope
#33
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 84.06% 86.41% +2.34%
==========================================
Files 2 2
Lines 251 287 +36
==========================================
+ Hits 211 248 +37
+ Misses 33 32 -1
Partials 7 7 ☔ View full report in Codecov by Sentry. |
5b0a36c
to
2b805a7
Compare
@mattdowdell could you please take a look? |
@tmzane Pologies for missing this. The code changes look reasonable, as do the tests. But I wondered what happens when this gets picked up by golangci-lint. Should we also map "true" to "all" to preserve the old behaviour? |
@mattdowdell no worries, thanks for the post merge review :)
I guess this could work for yaml configs but not for stricter formats, such as json and toml (IIRC, both are supported by golangci-lint). Instead, we decided to deprecate the old option and add a new one that accepts strings. |
Closes #29