Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement -no-global #32

Merged
merged 2 commits into from
Mar 17, 2024
Merged

feat: implement -no-global #32

merged 2 commits into from
Mar 17, 2024

Conversation

tmzane
Copy link
Member

@tmzane tmzane commented Mar 16, 2024

Closes #30

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 69.44444% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 84.06%. Comparing base (b258907) to head (7a56fe5).

Files Patch % Lines
sloglint.go 69.44% 7 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   84.75%   84.06%   -0.69%     
==========================================
  Files           2        2              
  Lines         223      251      +28     
==========================================
+ Hits          189      211      +22     
- Misses         29       33       +4     
- Partials        5        7       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmzane tmzane requested a review from mattdowdell March 16, 2024 19:06
Copy link
Collaborator

@mattdowdell mattdowdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@tmzane tmzane merged commit f87bbdf into main Mar 17, 2024
8 of 10 checks passed
@tmzane tmzane deleted the no-global branch March 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to disallow the usage of default logger
2 participants