Add validation for brackets in plain metrics and regex error parsing for tagged metrics #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an incorrect regex is sent to clickhouse, graphite-clickhouse will return
500: Storage error
which is not very informative. This PR adds validation before that can happen to avoid making unnecessary requests to clickhouse and makes graphite-clickhouse return an error that explains the reason why.For plain metrics: check if all brackets are closed correctly within each node of the path.
Example:
a.b.c{d,e}}.f
would now return400: query has unmatched brackets
For tagged metrics: parse regex error from clickhouse.
Example:
seriesByTag('name=myMetric', 'tag=*abc*')
would now return400: Incorrect regex syntax