Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DoesntStartWithValidator #207

Merged
merged 4 commits into from
Jun 15, 2024

Conversation

saltyFamiliar
Copy link
Contributor

References

Issue(s): #202

Description

I implemented DoesntStartWithValidator using the validators in validation/string.go as a reference. I also added a corresponding test in validation/string_test.go and updated lang/default.go with two entries: "doesnt_start_with" and "doesnt_start_with.element".

Possible drawbacks

DoesntStartWithValidator.Validate returns true for non-string values. Maybe it should return some kind of error.

@System-Glitch System-Glitch self-requested a review June 14, 2024 09:20
@System-Glitch System-Glitch self-assigned this Jun 14, 2024
validation/string.go Outdated Show resolved Hide resolved
validation/string_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9522678418

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 97.31%

Totals Coverage Status
Change from base Build 9501807432: 0.007%
Covered Lines: 6042
Relevant Lines: 6209

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9522758672

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 97.31%

Totals Coverage Status
Change from base Build 9518779548: 0.006%
Covered Lines: 6042
Relevant Lines: 6209

💛 - Coveralls

@System-Glitch System-Glitch merged commit c4e3b6f into go-goyave:master Jun 15, 2024
4 checks passed
@System-Glitch
Copy link
Member

Thank you very much! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants