Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make file interface a bit more interoperable #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make file interface a bit more interoperable #6

wants to merge 1 commit into from

Conversation

c4milo
Copy link

@c4milo c4milo commented Aug 5, 2020

Even though, Readdir is not needed within go-git.

@c4milo c4milo mentioned this pull request Aug 5, 2020
Open
@c4milo c4milo force-pushed the master branch 2 times, most recently from 852b3be to 6772e89 Compare August 5, 2020 17:14
smola
smola reviewed Aug 5, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@c4milo c4milo requested a review from smola August 5, 2020 20:35
@tie
Copy link

tie commented Aug 17, 2020

Looks like a breaking change since it modifies billy.File interface.

I’ve opened a similar PR #7 that adds billy.Stat function using optional interface pattern to call Stat on billy.File. This approach seems applicable here as well.

@mcuadros mcuadros force-pushed the master branch 6 times, most recently from 609712c to 3d7f61f Compare April 21, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola Awaiting requested review from smola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c4milo @tie @smola