Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused func argument #36

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Remove unused func argument #36

merged 1 commit into from
Jul 25, 2024

Conversation

VojtechVitek
Copy link
Contributor

The in-memory counter doesn't require time window to be hashed anymore, since we started using two sliding counter hash maps instead of a single hash map.

The in-memory counter doesn't require time window to be hashed
anymore, since we started using two sliding counter hash maps
instead of a single hash map.
Copy link

Benchmark Results

goos: linux
goarch: amd64
pkg: github.com/go-chi/httprate
cpu: AMD EPYC 7763 64-Core Processor                
               │ master.txt  │               pr.txt               │
               │   sec/op    │   sec/op     vs base               │
LocalCounter-4   19.33m ± 1%   19.55m ± 1%  +1.13% (p=0.000 n=10)

               │  master.txt  │             pr.txt             │
               │     B/op     │     B/op      vs base          │
LocalCounter-4   2.834Mi ± 0%   2.834Mi ± 0%  ~ (p=0.481 n=10)

               │ master.txt  │            pr.txt             │
               │  allocs/op  │  allocs/op   vs base          │
LocalCounter-4   121.5k ± 0%   121.5k ± 0%  ~ (p=0.541 n=10)

@VojtechVitek VojtechVitek merged commit 7fd4d55 into master Jul 25, 2024
3 checks passed
@VojtechVitek VojtechVitek deleted the YM9IdCXs branch July 25, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant