add pebble version check #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marino39
requested changes
Feb 19, 2024
marino39
approved these changes
Feb 19, 2024
|
very helpful. what should we do in cases when we want for bond to proceed to open..? |
|
@pkieltyka we have migration framework planned for that. |
|
BTW: @poonai I forgot that the ticket also mentioned implementing the pebble format migration mechanism. Please do that in this ticket too. |
marino39
approved these changes
Feb 20, 2024
bond.go
Outdated
| } | ||
| } | ||
|
|
||
| pebbelVersionPath := filepath.Join(bondPath, "PEBBLE_FORMAT_VERSION") |
There was a problem hiding this comment.
Use const for bond and PEBBLE_FORMAT_VERSION. It just makes any changes easier by just editing the const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #124