Persist STRICT_APPLE_COMPATIBILITY in objc-config.h #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchisnall
approved these changes
Nov 18, 2024
|
Might be good to propagate the other build-time configuration things there. |
|
@davidchisnall Sure, which ones would you like? Some of them have generic names (e.g. |
On Windows, the value of `STRICT_APPLE_COMPATIBILITY` determines whether `BOOL` is a char or an int. This value must be consistent across all libraries that use libobjc2. Rather than requiring all libraries to explicitly define `STRICT_APPLE_COMPATIBILITY`, persist the value of `STRICT_APPLE_COMPATIBILITY` in `objc-config.h` and include that in `runtime.h`.
|
I'll merge as is but we can always add more configuration data later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the value of
STRICT_APPLE_COMPATIBILITYdetermines whetherBOOLis a char or an int. This value must be consistent across all libraries that use libobjc2. Rather than requiring all libraries to explicitly defineSTRICT_APPLE_COMPATIBILITY, persist the value ofSTRICT_APPLE_COMPATIBILITYinobjc-config.hand include that inruntime.h.