remove contract detection by bytecode

this blows up the bundle size and is super unreliable (not supporting minor version changes, not supporting libraries), i don't see any real world use case where this would come in helpful
gnosisguild · Jan 9, 2024 · 9627896 · 9627896
1 parent 2ca2b83
commit 9627896
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 22 deletions.
diff --git a/packages/app/src/utils/contracts.ts b/packages/app/src/utils/contracts.ts
@@ -10,7 +10,6 @@ import SafeAppsSDK from "@gnosis.pm/safe-apps-sdk"
 import {
   getGenericProxyMaster,
   getModuleContractMetadata,
-  getModuleContractMetadataByBytecode,
   getProxyMaster,
   isGenericProxy,
   isGnosisGenericProxy,
@@ -194,15 +193,6 @@ export const getModuleData = memoize(
       }
     }
 
-    const standardContract = getModuleContractMetadataByBytecode(bytecode)
-    if (standardContract) {
-      return {
-        address,
-        implAddress: address,
-        ...standardContract,
-      }
-    }
-
     try {
       const { ABI, ContractName } = await fetchContractSourceCode(chainId, address)
 

diff --git a/packages/app/src/utils/modulesValidation.ts b/packages/app/src/utils/modulesValidation.ts
@@ -21,7 +21,7 @@ const MODULES_METADATA = {
   [ModuleType.EXIT]: EXIT_MODULE_METADATA,
   [ModuleType.BRIDGE]: BRIDGE_MODULE_METADATA,
   [ModuleType.DELAY]: DELAY_MODIFIER_METADATA,
-  [ModuleType.ROLES]: ROLES_MODIFIER_METADATA,
+  [ModuleType.ROLES_V1]: ROLES_MODIFIER_METADATA,
   [ModuleType.OZ_GOVERNOR]: OZ_GOVERNOR_METADATA,
   [ModuleType.CONNEXT]: CONNEXT_METADATA,
 }
@@ -46,17 +46,6 @@ export function getModuleContractMetadata(
   return { type: module, ...MODULES_METADATA[module] }
 }
 
-export function getModuleContractMetadataByBytecode(
-  bytecode: string,
-): ModuleContractMetadata | undefined {
-  const entry = Object.entries(MODULES_METADATA).find(
-    ([, metadata]) => metadata.bytecode === bytecode.toLowerCase().trim(),
-  )
-  if (!entry) return
-  const [type, metadata] = entry
-  return { ...metadata, type: getModuleType(type) }
-}
-
 export function isGnosisGenericProxy(bytecode: string) {
   return bytecode.toLowerCase() === GNOSIS_GENERIC_PROXY_CONTRACT_BYTECODE
 }