Stop relying exclusively on Infura for IPFS #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgeir-s
reviewed
Jan 24, 2023
There was a problem hiding this comment.
Nice, it works when I specify my private IPFS node :D
In regards to the fallback; I have set it up to work with Infura as a fallback. You just need to set the REACT_APP_IPFS_INFURA_PROJECT_ID and REACT_APP_IPFS_INFURA_SECRET_KEY environment variables.
Two comments:
-
We are missing the check for whether it's able to connect to the IPFS node. Perhaps a notification with something like "unable to connect to the specified IPFS node, will use Infura" if it can not connect?
-
I think we should stick with one kind of model, now, we have different modals for updating the pinning service and updating the IPFS node.
|
I added a commit where we remove Infura as a fallback and instead spin up an IPFS node in the browser. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27
FYI: #27 (comment)
UI
