Spec Gnosis Chain withdrawals #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
Jan 5, 2023
3 tasks
execution/withdrawals.md
Outdated
| gas_limit: TBD | ||
| max_priority_fee_per_gas: 0 | ||
| max_fee_per_gas: 0 | ||
| gas_limit: 1600000 |
There was a problem hiding this comment.
Might be too low for complex logic
There was a problem hiding this comment.
Right. ERC20 transfers can require 50-200k gas. With 16 widrawals per block * 200k = 3.2M. Will increase to 30,000,000 (= block gas limit) as an arbitrary higher value.
yperbasis
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec Gnosis Chain withdrawals, extending ethereum/eip-4895.
Content and todos
CC: @LukaszRozmej @jmederosalvarado @yperbasis