Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix claiming on unsupported network #777

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Fix claiming on unsupported network #777

merged 1 commit into from
Jul 12, 2021

Conversation

ramirotw
Copy link
Contributor

Closes #746

@ramirotw ramirotw requested review from henrypalacios and josojo July 12, 2021 12:54
@ramirotw ramirotw force-pushed the ramirotw/issue-746-claim-wrong-network branch from caddca6 to 140bd76 Compare July 12, 2021 12:59
@github-actions
Copy link

  • 🔭 IDO UI: Easy IDO auction

@elena-zh elena-zh mentioned this pull request Jul 12, 2021
Open
@elena-zh
Copy link

@ramirotw , changes LGTM.
I have created separate tickets for the next issues, related to this pr:

  1. claim button is disabled when claim funds under 1st account and then switch to the 2nd one Claim button is disabled when claim funds under 1st account and then switch to the 2nd account #778
  2. message on the 'Claim' button is changed when reload the page, user is in another network: Message is changed on the Claim button when reload a page #779

@ramirotw ramirotw merged commit c50a664 into develop Jul 12, 2021
@ramirotw ramirotw deleted the ramirotw/issue-746-claim-wrong-network branch July 12, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josojo josojo josojo approved these changes

@henrypalacios henrypalacios Awaiting requested review from henrypalacios

Assignees
No one assigned
Labels
QA passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User is able to claim funds in another supported network
3 participants
@ramirotw @elena-zh @josojo