Activate wallet-connect deeplink with qr-mode #650

henrypalacios · 2021-06-03T22:27:51Z

closes: #562

Activate walletconnect deeplink.

⚠️ Problems related to this PR:

Functionality Issue: Walletconnect modal appears again after a wallet disconnection #671
UI issues: On a HD screen both the modal's header and the copy tooltip are not 100% visible #670, Cross icon in the WalletConnect modal has double lines #659

github-actions · 2021-06-04T21:05:23Z

🔭 IDO UI: Easy IDO auction

henrypalacios · 2021-06-05T00:08:14Z

src/theme/globalStyle.tsx

@@ -26,7 +26,7 @@ export const GlobalStyle = createGlobalStyle<{ theme: any }>`

 export const ThemedGlobalStyle = createGlobalStyle`
  html {
-    color: ${({ theme }) => theme.text1};
+    color: ${({ theme }) => theme.text4};


walletconnect modal take the body>color style, I found no other way to change the text color, and it does not seem to affect anything, what do you think @alongoni?

josojo

Nice, really like tthis PR. Big improvement.

Well done!

elena-zh · 2021-06-07T09:30:55Z

Hey @henrypalacios , @josojo
I have verified the issue. Great job! However, here are several notes:

I have not been able to connect the app with the Safe app. See the video:
https://drive.google.com/file/d/1LK8K4uXiIvfyYoouOYWwkpjlXOA7HXh_/view
Sometimes the link is not copied: I see the message that it was copied, but when I paste it, I see the previously copied value
https://drive.google.com/file/d/1aurDHyED-B2q2gyYkhXpenaTFotmi0bN/view
Cross icon in the WalletConnect modal has double lines
These issues might not be related to our current implementation but to the integrated component, however, I have to mention that:
4.1. 404 page is opened when call connection in iOS using

Crypto.com
1inch
CYBAVO
AlphaWallet
EasyPocket
SparkPoint
PEAKDEFI
Aktionariat
Flare
AToken
Tongue
RWallet
PlasmaPay
O3Wallet
Defiant
4.2. Nothing happens, when the next apps are not installed in an iOS mobile device:
Pillar
Argent
ImToken
TokenPocket
Ledger
Dharma
Huobi
HaloDefi

I'm not able to see app's list in my Android device:

Could you please take a look into these issues?

Thanks

henrypalacios · 2021-06-08T21:45:23Z

Thanks by your notes @elena-zh, with regard to the points discussed:

1
This surely had to do with the point 2.
2
Please try again.
3
This has to do with the modal that comes with the package, I don't know if it can be improved in any way, maybe @alongoni can suggest something.
4
I have not been able to reproduce this, but yes, surely this has to do with the walletconnect package.
5
I'm not sure if it looks different on iOS, but on Android after pressing connect, the possible options appears.

elena-zh · 2021-06-09T09:02:06Z

Hi @henrypalacios , great job!

Cases 1-2 are fixed.
I have created a separate issue for the case 3 - Cross icon in the WalletConnect modal has double lines #659 and assigned @alongoni to it.
As for the cases 4 and 5. In Android it works fine: the app suggests a user to open any supported app which can be connected using WalletConnect option.
However, the issue I mentioned is still reproducible on iOS devices.
@josojo , could you please take a look at the case 4 in my previous comment and clarify whether we should leave it as it is?
The issue is that for several apps nothing happens when a user selects them in case if they are not installed to the device. Another case that a lot of apps navigate to the 404 page when select them.
Also, I have faced another issue that is related to this pr: walletconnect modal appears after disconnection of a wallet. And it is not closed when connect a wallet using it once again. @henrypalacios , could you please take a look at it?
https://drive.google.com/file/d/1POb25DYAo20pKUplDAEVJmkVWA8uuY82/view
BTW, we have an low priority issue [connect a wallet modal] wrong header #599 on the board related to a modal header name. Could you please fix it in this pr?

Thanks

josojo · 2021-06-09T10:29:31Z

@josojo , could you please take a look at the case 4 in my previous comment and clarify whether we should leave it as it is?
The issue is that for several apps nothing happens when a user selects them in case if they are not installed to the device. Another case that a lot of apps navigate to the 404 page when select them.

Yes, this is fine, let's not change anything

ramirotw · 2021-06-09T13:22:36Z

Also, I have faced another issue that is related to this pr: walletconnect modal appears after disconnection of a wallet. And it is not closed when connect a wallet using it once again. @henrypalacios , could you please take a look at it?
https://drive.google.com/file/d/1POb25DYAo20pKUplDAEVJmkVWA8uuY82/view

Might be related to #600

ramirotw · 2021-06-09T13:30:02Z

Also, on a HD screen both the modal's header and the copy tooltip are not 100% visible

henrypalacios · 2021-06-10T02:45:51Z

@elena-zh continuing your notes:

Also, I have faced another issue that is related to this pr: walletconnect modal appears after disconnection of a wallet. And it is not closed when connect a wallet using it once again. @henrypalacios , could you please take a look at it?

I have not been able to find a way to solve this, the problem is associated when the walletconnect modal appears immediately after disconnecting. The strange thing is that at times it works and at other times it does not. As in this video that occurs after the third attemp

Could you please fix it in this pr?

closes #599 also.

@ramirotw

Might be related to #600

@ramirotw It doesn't look like it because when refreshing walletconnect it is not really there (it is the InjectedConnector that remains).

Also, on a HD screen both the modal's header and the copy tooltip are not 100% visible.

Do you think we should open another issue for that, since I'm not sure if it's possible to just make a wrapper?

elena-zh · 2021-06-10T08:12:04Z

Hi @henrypalacios ,
#599 Looks good to me now!

However, today I have not been able to connect a wallet using walletconnect option: each time when I select this option, I get the app crash =(

As for the mentioned above issues, I have created tickets for them:
#670 - truncated modal header
#671 - Walletconnect modal appears after a wallet disconnection

Thanks

henrypalacios · 2021-06-10T15:15:09Z

NoCloses 671 (failed)

josojo · 2021-06-11T08:10:35Z

@henrypalacios can you give a summary on what is working and what is not working?

Do you need help with anything particular? It would be great if we can get it ready for release.

elena-zh · 2021-06-11T10:24:49Z

@henrypalacios , @josojo ,
I have retested the PR. Here are my notes:

Walletconnect modal appears again after a wallet disconnection #671 is still reproducible: connection window may appear again (50/50%) when I press on the 'Disconnect' button. I think, It worth fixing before the release due to connection does not work as expected when reconnect a wallet from the newly appeared modal window (see the issue description)
Connection with Gnosis Safe works fine. I was able to run place/cancel/claim order transactions from safe, however, transaction status is not tracked: all transactions are in 'Pending' status in the GA app even if they are successfully completed: Claiming/placing/cancelling order process hangs when interact with Gnosis Safe #675. I think, we should fix it before the release.
I have to notice, that transactions appropriately change their status when use walletconnect via barcode.
still, there are several UI issues unfixed (On a HD screen both the modal's header and the copy tooltip are not 100% visible #670, Cross icon in the WalletConnect modal has double lines #659 ), but they are not high priority ones and can be fixed later.

Thanks

elena-zh · 2021-06-16T11:09:36Z

Hi @henrypalacios , @hpmaxi ,
the #671 issue seems to be fixed now.
As for the pending transactions issue, I cannot say that it is fixed. Now all 'pending' transactions do not appear at all: when I place an order, it is not displayed in the 'Your orders' section with 'pending' state.
Also, no confirmation pop-ups when a transaction ends. Then, nothing is displayed in the 'Your transactions' list even after reloading the app
https://drive.google.com/file/d/1alYBP2fdT47AqVqLLntj_n0bq2MRBtES/view

hpmaxi · 2021-06-16T14:24:24Z

@elena-zh @josojo
I think this could be closed and make another issue with the safe related issues of the Elena's last comment. And close #671 too.

About safe, as far as I know, we are not updating the transactions state with the internal calls made by the safe, so maybe fixing that is completely unrelated to qr-mode.

[UPDATE]
@henrypalacios said that was able to reproduce #671 , but I think that could be made in another branch too.

elena-zh · 2021-06-16T14:58:17Z

Hi @hpmaxi , here a separate issue for Gnosis Safe transactions #693.
I was also able to reproduce #671 issue again - a reopened it and put it into the Review state. If we take a decision to fix it in another branch, it would be nice to unlink it from this PR and then move it into another column on the board.

Thanks

josojo · 2021-06-21T10:55:45Z

Yes, I think its fine to track them with issues and merge what we have already.

henrypalacios · 2021-06-22T21:07:08Z

In this PR try to handle the error #658 when the app is crashed when connect a wallet with another unsupported network

elena-zh · 2021-06-23T11:26:35Z

Hi @henrypalacios , thank you for the fix!
Now the app is not crashed, however, works a bit strange. Look:

When I connect to another supported network, I receive an error message to change a network.
A lot of errors in console appear right after connection
here is the video: https://drive.google.com/file/d/10AGylZilk3K166nEHCnK2JbrZl_ae57r/view

It would be great to use the same flow as it works for Metamask connection:

show a connected state with a message to select another network instead of the 'Connect wallet' button when a user is connected to a supported network
show an error and do not connect when a user is not in supported network.
Metamask flow: https://drive.google.com/file/d/1eORx4AoXUnaavA-GPcuEIFyQaIN0kYY_/view

henrypalacios · 2021-06-23T15:09:15Z

Ok @elena-zh , I'm going to revert the changes related with #658 by merged this PR, and I will continue it there.

Activate wallet-connect qr-mode

c4faa2c

henrypalacios marked this pull request as draft June 3, 2021 22:33

Fix when the walletconnect modal is reopened

944eb05

henrypalacios commented Jun 5, 2021

View reviewed changes

henrypalacios marked this pull request as ready for review June 5, 2021 00:17

henrypalacios requested review from josojo and ramirotw June 5, 2021 00:17

josojo approved these changes Jun 7, 2021

View reviewed changes

Add resolution web3-provider to fix copy to clipboard

7114ae9

elena-zh mentioned this pull request Jun 9, 2021

Cross icon in the WalletConnect modal has double lines #659

Closed

Fix issue 599

ca773ba

elena-zh mentioned this pull request Jun 10, 2021

On a HD screen both the modal's header and the copy tooltip are not 100% visible #670

Open

elena-zh mentioned this pull request Jun 10, 2021

Walletconnect modal appears again after a wallet disconnection #671

Open

Fix overlay walletconnect modal after disconnect

8c9b81b

Remove unused

08226f0

elena-zh mentioned this pull request Jun 11, 2021

Claiming/placing/cancelling order process hangs when interact with Gnosis Safe #675

Open

Merge branch 'develop' of github.com:gnosis/ido-ux into issue-562

62c82c4

elena-zh mentioned this pull request Jun 16, 2021

Transactions do not appear in the app when connect to a Gnosis safe #693

Closed

elena-zh added the QA passed label Jun 16, 2021

remove unnecessary parameter

eedb6f7

elena-zh mentioned this pull request Jun 22, 2021

[connect a wallet modal] wrong header #599

Closed

henrypalacios added 2 commits June 22, 2021 15:35

Merge branch 'develop' of github.com:gnosis/ido-ux into issue-562

f8f482f

try to handle the error when walletconnect throws No RPC Url available

25bf912

Merge branch 'develop' of github.com:gnosis/ido-ux into issue-562

a8940c4

Revert changes related to unsopported chainID with walletconnect

58c5709

henrypalacios merged commit dedc427 into develop Jun 23, 2021

henrypalacios deleted the issue-562 branch June 23, 2021 15:10

henrypalacios mentioned this pull request Jun 23, 2021

Handling app crashing when walletconnect is using another supported network #730

Merged

1 task

elena-zh mentioned this pull request Jul 7, 2021

WC not working on mobile gnosis/cowswap#862

Closed

henrypalacios mentioned this pull request Sep 14, 2021

Bugfix - Copy to clipboard button not working on Wallet connect popup gnosis/cowswap#1434

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Activate wallet-connect deeplink with qr-mode #650

Activate wallet-connect deeplink with qr-mode #650

henrypalacios commented Jun 3, 2021 •

edited

Loading

github-actions bot commented Jun 4, 2021

henrypalacios Jun 5, 2021 •

edited

Loading

josojo left a comment

elena-zh commented Jun 7, 2021 •

edited

Loading

henrypalacios commented Jun 8, 2021

elena-zh commented Jun 9, 2021 •

edited

Loading

josojo commented Jun 9, 2021

ramirotw commented Jun 9, 2021

ramirotw commented Jun 9, 2021

henrypalacios commented Jun 10, 2021

elena-zh commented Jun 10, 2021

henrypalacios commented Jun 10, 2021 •

edited

Loading

josojo commented Jun 11, 2021

elena-zh commented Jun 11, 2021

elena-zh commented Jun 16, 2021

hpmaxi commented Jun 16, 2021 •

edited

Loading

elena-zh commented Jun 16, 2021

josojo commented Jun 21, 2021

henrypalacios commented Jun 22, 2021 •

edited

Loading

elena-zh commented Jun 23, 2021 •

edited

Loading

henrypalacios commented Jun 23, 2021

Activate wallet-connect deeplink with qr-mode #650

Activate wallet-connect deeplink with qr-mode #650

Conversation

henrypalacios commented Jun 3, 2021 • edited Loading

github-actions bot commented Jun 4, 2021

henrypalacios Jun 5, 2021 • edited Loading

Choose a reason for hiding this comment

josojo left a comment

Choose a reason for hiding this comment

elena-zh commented Jun 7, 2021 • edited Loading

henrypalacios commented Jun 8, 2021

elena-zh commented Jun 9, 2021 • edited Loading

josojo commented Jun 9, 2021

ramirotw commented Jun 9, 2021

ramirotw commented Jun 9, 2021

henrypalacios commented Jun 10, 2021

@elena-zh continuing your notes:

@ramirotw

elena-zh commented Jun 10, 2021

henrypalacios commented Jun 10, 2021 • edited Loading

josojo commented Jun 11, 2021

elena-zh commented Jun 11, 2021

elena-zh commented Jun 16, 2021

hpmaxi commented Jun 16, 2021 • edited Loading

elena-zh commented Jun 16, 2021

josojo commented Jun 21, 2021

henrypalacios commented Jun 22, 2021 • edited Loading

elena-zh commented Jun 23, 2021 • edited Loading

henrypalacios commented Jun 23, 2021

henrypalacios commented Jun 3, 2021 •

edited

Loading

henrypalacios Jun 5, 2021 •

edited

Loading

elena-zh commented Jun 7, 2021 •

edited

Loading

elena-zh commented Jun 9, 2021 •

edited

Loading

henrypalacios commented Jun 10, 2021 •

edited

Loading

hpmaxi commented Jun 16, 2021 •

edited

Loading

henrypalacios commented Jun 22, 2021 •

edited

Loading

elena-zh commented Jun 23, 2021 •

edited

Loading