Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Safe App Grant Proposal - Idle Finance #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

krzysu
Copy link

@krzysu krzysu commented May 28, 2020

Safe App Grant Proposal - Idle Finance

@GnosisEcosystemFund
Copy link
Contributor

Thank you for submitting the proposal! Please go ahead and let me know if you have any questions. I tried to connect via twitter but seems your DMs aren't open.

@krzysu
Copy link
Author

krzysu commented Jun 4, 2020

I've just opened DMs on my twitter, please contact me there or by email (in the proposal or you can find it on my Github account)

@krzysu
Copy link
Author

krzysu commented Jun 17, 2020

I added links to the code repository, hosted versions of the app, including IPFS hash and simple gif screencast showing the features of the app. Let me know if all grant requirements are met here.
If you want to preview the gifs, open this page: https://github.com/krzysu/GECO/blob/master/Proposals/IdleFinance/IdleFinance.md

@lukasschor
Copy link
Contributor

Nice that you included the number formating!

Just one place where I think it could be nice to remove trailing zeros. But I think it's not super critical.

image

@lukasschor
Copy link
Contributor

image

On MacOS, the scrollbar overlays a bit with the withdrawal buttons. But that's also not critical at all, and I understand if that's not worth the effort to implement some padding. Just wanted to let you know. :)

@krzysu
Copy link
Author

krzysu commented Jun 19, 2020

@lukasschor I updated the app with your suggestions. Also updated the IPFS hash in the grant PR

@krzysu
Copy link
Author

krzysu commented Jun 23, 2020

@lukasschor @GnosisEcosystemFund That is the final version of the Idle Safe App, please review and let me know when do you plan to do the official release and announcement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants