Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move node configuration code to separate classes #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

masgari
Copy link

@masgari masgari commented May 13, 2022

Replacing EnigmaIOTNodeSerialConfigurerClass with current WifiManager makes onboarding simpler, also reduces ~200KB in final firmware size, make it possible to use it with boards with 1MB flash while OTA enabled.

    //nodeConfigurer_t configurer = std::bind(&EnigmaIOTNodeJsonConfigurerClass::configure, &EnigmaIOTNodeJsonConfigurer, std::placeholders::_1);
    nodeConfigurer_t configurer = std::bind(&EnigmaIOTNodeSerialConfigurerClass::configure, &EnigmaIOTNodeSerialConfigurer, std::placeholders::_1);
    //nodeConfigurer_t configurer = std::bind(&EnigmaIOTNodeWifiConfigurerClass::configure, &EnigmaIOTNodeWifiConfigurer, std::placeholders::_1);
    EnigmaIOTNode.begin(&Espnow_hal, NULL, NULL, true, SLEEPY == 1, configurer);  // Start EnigmaIOT communication

@gmag11
Copy link
Owner

gmag11 commented Sep 20, 2022

Hi, I've been offline for a while. This sounds really fine. I'll be happy to merge it. Give me some days to test it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants