Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach EP to get allowed_functions via stdin #1737

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

khk-globus
Copy link
Contributor

The EP now can receive a list of allowed functions via the allowed_functions key in the JSON dictionary received on stdin. Crucially, if a list is passed in via stdin, it takes precedence over what may or may not be in the configuration file. This makes it easier for a parent MEP to ensure that child UEPs have exactly the same allow list, enabling that both the web-service and the UEP verify that a function is allowed.

Type of change

  • Bug fix

@khk-globus khk-globus added no-news-is-good-news This change does not require a news file quick-review Review of this should be quick and easy labels Dec 4, 2024
LeiGlobus
LeiGlobus previously approved these changes Dec 4, 2024
Copy link
Contributor

@LeiGlobus LeiGlobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to merge, but the '0' may need more thinking on.

compute_endpoint/globus_compute_endpoint/cli.py Outdated Show resolved Hide resolved
The EP now can receive a list of allowed functions via the `allowed_functions`
key in the JSON dictionary received on `stdin`.  Crucially, if a list is passed
in via `stdin`, it takes precedence over what may or may not be in the
configuration file.  This makes it easier for a parent MEP to ensure that child
UEPs have exactly the same allow list, enabling that both the web-service *and*
the UEP verify that a function is allowed.
@khk-globus khk-globus merged commit 689f656 into main Dec 4, 2024
21 checks passed
@khk-globus khk-globus deleted the add_allowed_functions_to_stdin_dict branch December 4, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-news-is-good-news This change does not require a news file quick-review Review of this should be quick and easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants