add high-assurance placeholder option to endpoint configuration #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiGlobus
added
the
no-news-is-good-news
LeiGlobus
force-pushed
the
ha-endpoints-sc-35308
branch
from
9b54d36 to
abb4a3a
Compare
LeiGlobus
force-pushed
the
ha-endpoints-sc-35308
branch
from
abb4a3a to
e4fd088
Compare
khk-globus
reviewed
Dec 5, 2024
Comment on lines
6
to
8
| display_name=None, # If None, defaults to the endpoint name | ||
| high_assurance=False, | ||
| executors=[ |
There was a problem hiding this comment.
If it defaults to False, per config.py, why include this at all in the default_config.py? Especially since this is yet a hidden feature (per "in-development!") given cli.py?
Comment on lines
+86
to
+89
| if ha is True: | ||
| assert "high_assurance" in config_dict | ||
| else: | ||
| assert "high_assurance" not in config_dict |
There was a problem hiding this comment.
This can be reduced to:
assert ("high_assurance" in config_dict) is (ha is True)
Comment on lines
45
to
+47
| class BaseConfigModel(BaseModel): | ||
| multi_user: t.Optional[bool] | ||
| high_assurance: t.Optional[bool] |
There was a problem hiding this comment.
Ah, need to rebase on main, we just updated this per the 2.32.1 bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the skeleton of adding high-assurance to endpoint configuration.
The option in
globus-compute-endpoint configure --high-assuranceis marked as hidden for now.Like multi-user, the config is only present in the config file if it is True. The web service treats missing values as False as well.
Obviously no changelog fragment for now.
For a bit more context see SC https://github.com/globusonline/funcx-services/pull/726
V3 register adds the high_assurance option if provided, V2 does not support registration with the value set to True. However GET /v2/endpoint does return the value.