Update Polaris example config #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to MpiExecLauncher over SingleNodeLauncher, as the former is more useful * Demonstrate capability to pin each worker to a unique GPU
chris-janidlo
added
the
no-news-is-good-news
WardLT
approved these changes
May 23, 2023
| @@ -15,17 +15,21 @@ | |||
| 'scheduler_options': '#PBS -l filesystems=home:grand:eagle\n#PBS -k doe', | |||
| # ALCF allocation to use | |||
| 'account': '', | |||
| # Un-comment to give each worker exclusive access to a single GPU | |||
There was a problem hiding this comment.
Why make GPU pinning opt-in?
I would vote for opt out for this option because it's rare for apps to fairly share GPUs amongst themselves (I don't know if any), so this default would lead to bad performance.
The balancing point to my suggestion is that restarting workers or reassigning them to different types is broken with accelerator pinning. (sorry, I don't recall the number of the issue I made about it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of some PR spring cleaning, addressing #951 by including the suggested update from
SingleNodeLaunchertoMpiExecLauncher, and showing off the ability to pin workers to GPUs via an optional user-opt.Type of change