-
Notifications
You must be signed in to change notification settings - Fork 48
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
To date, we've been comingling the MEP and UEP configurations in `Config`. At this time, the two implementations are starting to diverge in their overlap, so bite the bullet and be clear about the differences. This implementation uses `BaseConfig` for the shared attributes, maintains `Config` for backward compatability, and introduces `UserEndpointConfig` for the user endpoint and `ManagerEndpointConfig` for the endpoint manager configuration. The core of the changes start in `endpoint/config/config.py`, where `UserEndpointConfig` (for UEPs) and `ManagerEndpointConfig` (for MEPs) are defined. These are backed up by requisite changes to the Pydantic model in `config/model.py`, Just about every other change is in support of the now-distinct configuration classes. Notes: - test coverage has increased around the configurations - the YAML facade shouldn't change at all from the user perspective. This is an internal organization detail [sc-37362]
- Loading branch information
1 parent
f35d3b4
commit f12b50b
Showing
26 changed files
with
845 additions
and
445 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 11 additions & 1 deletion
12
compute_endpoint/globus_compute_endpoint/endpoint/config/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,11 @@ | ||
from .config import Config # noqa: F401 | ||
from .config import ( # noqa: F401 | ||
BaseConfig, | ||
Config, | ||
ManagerEndpointConfig, | ||
UserEndpointConfig, | ||
) | ||
from .model import ( # noqa: F401 | ||
BaseConfigModel, | ||
ManagerEndpointConfigModel, | ||
UserEndpointConfigModel, | ||
) |
Oops, something went wrong.