-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing g1 landing page for "Desafio Globo" using Vanilla JS
, HTML
, CSS
and JSDoc
.
#2
Open
bwprado
wants to merge
98
commits into
globoi:master
Choose a base branch
from
bwprado:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwprado
changed the title
Implementing **g1** landing page for _"Desafio Globo"_ using
Implementing g1 landing page for "Desafio Globo" using Dec 11, 2023
Vanilla JS
, HTML
, CSS
and JSDoc
.Vanilla JS
, HTML
, CSS
and JSDoc
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR is part of the "Desafio Globo" and it its the recreation of the g1.globo.com landing page following the challenge directives found on Portifólio Recrutamento.
The directives were all met and completed accordingly with some amount of freedom, for example the top 3 news section was closely matched to the current g1.globo.com version.
Selected Approaches:
Some other different approaches were taken as parte of this challenge:
WebComponent
to encapsulate the News List, that can be reused on other parts of the website.What could be done differently?
As time as a constrain, many design and code choices were rushed, and many changes could be implemented on the future, including unit testing and better component encapsulation.
Here is the list of things that can/could be changed:
CustomElements
for other components.<news-list>
and other parts of the code.