Console warnings cleanup #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rathorevaibhav
requested review from
kurund and
a team
and removed request for
kurund
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed console warnings in Tag Add/Edit functionality.
Note
Not all warnings have been removed. A couple of them like the
unmounted componentandDOM render in Dropdownare library related issues. These will go away when the library is updated.Apollo React PR for
unmounted component:apollographql/react-apollo#4021
I suggest to wait for a few days to get these merged. We'll update the package to clean these warnings.
Also, these warnings only appear in React strictmode. These will not show up in production version.
Test Plan
No test cases here. Tag edit/add test cases to be covered in #14