Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use generics in SearchApi #1136

Merged
merged 1 commit into from
Oct 12, 2024
Merged

use generics in SearchApi #1136

merged 1 commit into from
Oct 12, 2024

Conversation

exaV
Copy link

@exaV exaV commented Jul 1, 2024

as proposed in #1134

Fixes #1134

@exaV
Copy link
Author

exaV commented Jul 1, 2024

It should work but I was unable to get the integration test to work. It fails with (even without my changes)

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.391 s <<< FAILURE! - in org.gitlab4j.api.TestSearchApi
org.gitlab4j.api.TestSearchApi  Time elapsed: 0.391 s  <<< ERROR!
org.gitlab4j.api.GitLabApiException: invalid_grant

@exaV
Copy link
Author

exaV commented Jul 2, 2024

Okay I was able to get the tests to work. After my latest change all tests in TestSearchApi are green.

To get it to run I had to remove seedData() method in org.gitlab4j.api.SetupIntegrationTestExtension#beforeAll in my local copy of the code.

@exaV
Copy link
Author

exaV commented Jul 2, 2024

@jmini please review

@exaV
Copy link
Author

exaV commented Sep 24, 2024

@jmini Please let me know if you need me to change something to get this merged

@jmini
Copy link
Collaborator

jmini commented Sep 25, 2024

Yes it is still on my TODO list to review this. Sorry for the delay.

@jmini jmini merged commit fa5eb83 into gitlab4j:6.x Oct 12, 2024
@jmini
Copy link
Collaborator

jmini commented Oct 12, 2024

Thank you very much for this contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants