Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace to user #1021

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add namespace to user #1021

merged 1 commit into from
Aug 23, 2023

Conversation

bensofficial
Copy link
Contributor

The problem arising is that the namespace id is not always equal to the user id.

Example:

  1. Create user: User Id 1, Namespace Id 1
  2. Create Group: Namespace Id 2
  3. Create user: User Id 2, Namespace Id 3

This PR adds the attribute to the user so that the information is available in a user object.

@bensofficial bensofficial marked this pull request as draft August 22, 2023 12:44
@bensofficial bensofficial reopened this Aug 22, 2023
@bensofficial bensofficial marked this pull request as ready for review August 22, 2023 13:14
@jmini jmini merged commit f9baa81 into gitlab4j:main Aug 23, 2023
2 checks passed
@jmini
Copy link
Collaborator

jmini commented Aug 23, 2023

Merged, thank you very much for this contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bensofficial @jmini