Make provider dropdown clickable area the full size of the visible UI element #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitkraken.atlassian.net/browse/GKCS-5674
select
elements can't have other tags inside them, only text, so at first I though I'd have to create a custom select implementation to handle the "prefix" (PRs: [icon]
), or add a dropdown or popover package, but I then thought of a much simpler solution: make the whole thing aselect
but give it margin left so I can show the custom "prefix" content over it.Before:
After:
A small side effect is the caret is closer to the edge but that's a result of the caret in native select elements always rendering outside of the select's padding.