Call check-in route when popup is opened #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miggy-e
approved these changes
May 3, 2024
Comment on lines
+50
to
+53
| // Don't check in more than once every 12 hours to reduce amount of requests | ||
| const { lastCheckin } = await storage.local.get('lastCheckin'); | ||
| if (lastCheckin && Date.now() - lastCheckin < 1000 * 60 * 60) { | ||
| return; |
There was a problem hiding this comment.
1: I think this currently checks every hour
2: is there a reason this is different than the gkdev checkin that's once every 24 hours?
There was a problem hiding this comment.
Good catch.
And I went with 12 instead of 24 for cases such as using it at 10am the first day and 9am the next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this PR conflicts with the event PR but it's a one line conflict, I'd rather avoid starting a PR train.
The route isn't live yet, I'll just hold off on merging this until after it is.