Cache Focus View data #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miggy-e
approved these changes
Apr 19, 2024
Comment on lines
+109
to
+118
| if (data && data.timestamp > Date.now() - cacheTimeMinutes * 60 * 1000) { | ||
| return data.data; | ||
| } | ||
|
|
||
| const newData = await fetchFn(); | ||
| if (newData) { | ||
| await storage.session.set({ [key]: { data: newData, timestamp: Date.now() } }); | ||
| } | ||
|
|
||
| return newData; |
There was a problem hiding this comment.
Should we still call the fetch if we get a cache hit? We can return the cached data, but refetch in the background
There was a problem hiding this comment.
for rate limit reasons I want to say, not immediately. we basically want to introduce the concept of cache time vs stale time (something that react-query has), so it fetches in the background only if the state time has passed. I want to do make caching a lot better in a followup but I currently have another branch on top of this so I'll revisit caching after that branch(es) get merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple version. I'll revisit the ideas we talked about it in the demo later but for now I'm switching focus to prioritize getting the core features in by Monday.