Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub commit injection #29

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Update GitHub commit injection #29

merged 4 commits into from
Apr 16, 2024

Conversation

gitkrakel
Copy link
Contributor

@gitkrakel gitkrakel commented Apr 16, 2024 •
edited
Loading

@gitkrakel gitkrakel self-assigned this Apr 16, 2024
@gitkrakel gitkrakel force-pushed the GKCS-5549-gkbe-update-github-commit-inje branch from 6a8d819 to a4189bd Compare April 16, 2024 18:02
@miggy-e
Copy link
Collaborator

miggy-e commented Apr 16, 2024

@gitkrakel while you're here, can you update the timeout-minutes in playwright.yml from 60 to 5?

miggy-e
miggy-e approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@miggy-e miggy-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks correct and the tests pass

@gitkrakel gitkrakel requested a review from miggy-e April 16, 2024 18:31
@gitkrakel
Copy link
Contributor Author

@miggy-e I'm re-requesting review because I made some additional changes:

  • fix no-shadow linting warnings
  • upgraded no-shadow lints to error

@gitkrakel gitkrakel merged commit c079c48 into main Apr 16, 2024
1 check passed
@gitkrakel gitkrakel deleted the GKCS-5549-gkbe-update-github-commit-inje branch April 16, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miggy-e miggy-e miggy-e approved these changes

@jdgarcia jdgarcia Awaiting requested review from jdgarcia

Assignees

@gitkrakel gitkrakel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitkrakel @miggy-e