Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKCS-4203 azure devops #11

Merged
merged 3 commits into from
Sep 22, 2023
Merged

GKCS-4203 azure devops #11

merged 3 commits into from
Sep 22, 2023

Conversation

miggy-e
Copy link
Collaborator

@miggy-e miggy-e commented Sep 19, 2023

https://gitkraken.atlassian.net/browse/GKCS-4203

adding azure devops links, is on top of #10 and will take out of draft once it is in.

@jdgarcia
Copy link
Contributor

@miggy-e did you accidentally yourself to this? not sure if you meant to assign someone else

@miggy-e
Copy link
Collaborator Author

miggy-e commented Sep 21, 2023

I feel like Miguel and Louis are used to assigning yourself and that means you're a person who'll merge it in?

@jdgarcia
Copy link
Contributor

pretty minor but the buttons don't line up correctly

image

@jdgarcia
Copy link
Contributor

oh, it's like that even without the extension lol. you can probably ignore that I guess 🤷

image

Copy link
Contributor

@gitkraken-jacobw gitkraken-jacobw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One problem to fix: The "Open with GitKraken" and "Open Comparison with GitKraken" links are the same, with both prompting to open the pull request remote.


Not your problem, but GKC deep link resolution was really freaking out this time. It thinks that I have two copies of the repos on my computer. Here's where it thinks the two copies are:
/home/me/Projects/frog-repo
/home/me/Projects/frog-repo/

That's right, it thinks those are two completely separate repos. When I tried opening a commit and chose the first repo, the link would fail to resolve. When I tried opening a "open repo" or branch deep link and selected the second option, it thinks that I don't have the repo's remote added and it prompts me to add it (I do have the remote added, albiet as an SSH url). This only happened for the "open repo"/branch link, the commit deep link worked as expected when I selected the second option. Not really sure what's going on here, but I'm pinning the blame on GKC since vscode seemed to work ok.

@miggy-e
Copy link
Collaborator Author

miggy-e commented Sep 22, 2023

One problem to fix: The "Open with GitKraken" and "Open Comparison with GitKraken" links are the same, with both prompting to open the pull request remote.

Not your problem, but GKC deep link resolution was really freaking out this time. It thinks that I have two copies of the repos on my computer. Here's where it thinks the two copies are: /home/me/Projects/frog-repo /home/me/Projects/frog-repo/

That's right, it thinks those are two completely separate repos. When I tried opening a commit and chose the first repo, the link would fail to resolve. When I tried opening a "open repo" or branch deep link and selected the second option, it thinks that I don't have the repo's remote added and it prompts me to add it (I do have the remote added, albiet as an SSH url). This only happened for the "open repo"/branch link, the commit deep link worked as expected when I selected the second option. Not really sure what's going on here, but I'm pinning the blame on GKC since vscode seemed to work ok.

Yea, Jordan has addressed that this is an issue with how gkc does repo-mapping, that it isn't trivial, and they should fix this. I can't seem to find it in slack

@miggy-e
Copy link
Collaborator Author

miggy-e commented Sep 22, 2023

@gitkraken-jacobw I was able to see your problem, but was unable to easily reproduce it making me think it's a timing issue, so I added a little bit of a wait to hopefully avoid this issue in the future. I wasn't able to get this issue to appear after updating.

@gitkraken-jacobw
Copy link
Contributor

Re-tested and LGTM

@miggy-e miggy-e merged commit 65e0dab into main Sep 22, 2023
1 check passed
@miggy-e miggy-e deleted the task/azuredevops branch September 22, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants