-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GKCS-4203 azure devops #11
Conversation
8bbb9a0
to
d8eac3b
Compare
d8eac3b
to
5accec8
Compare
@miggy-e did you accidentally yourself to this? not sure if you meant to assign someone else |
I feel like Miguel and Louis are used to assigning yourself and that means you're a person who'll merge it in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One problem to fix: The "Open with GitKraken" and "Open Comparison with GitKraken" links are the same, with both prompting to open the pull request remote.
Not your problem, but GKC deep link resolution was really freaking out this time. It thinks that I have two copies of the repos on my computer. Here's where it thinks the two copies are:
/home/me/Projects/frog-repo
/home/me/Projects/frog-repo/
That's right, it thinks those are two completely separate repos. When I tried opening a commit and chose the first repo, the link would fail to resolve. When I tried opening a "open repo" or branch deep link and selected the second option, it thinks that I don't have the repo's remote added and it prompts me to add it (I do have the remote added, albiet as an SSH url). This only happened for the "open repo"/branch link, the commit deep link worked as expected when I selected the second option. Not really sure what's going on here, but I'm pinning the blame on GKC since vscode seemed to work ok.
Yea, Jordan has addressed that this is an issue with how gkc does repo-mapping, that it isn't trivial, and they should fix this. I can't seem to find it in slack |
@gitkraken-jacobw I was able to see your problem, but was unable to easily reproduce it making me think it's a timing issue, so I added a little bit of a wait to hopefully avoid this issue in the future. I wasn't able to get this issue to appear after updating. |
Re-tested and LGTM |
https://gitkraken.atlassian.net/browse/GKCS-4203
adding azure devops links, is on top of #10 and will take out of draft once it is in.