Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vscode-app -> extension-app file to match convention #3545

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Apr 8, 2024

The ExtensionApp class was located a vscode-app.ts so I've renamed that to be extension-app.ts to match convention.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners April 8, 2024 14:42
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@charisk charisk merged commit 070df13 into main Apr 8, 2024
15 checks passed
@charisk charisk deleted the charisk/rename-extension-app-file branch April 8, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants