Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mocking of modeling events #3542

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Remove mocking of modeling events #3542

merged 2 commits into from
Apr 8, 2024

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Apr 5, 2024

There isn't a good reason to mock modeling events and it was making testing a bit awkward, so I've removed mocking and started using real MockModelingEvents instances.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk marked this pull request as ready for review April 5, 2024 15:22
@charisk charisk requested review from a team as code owners April 5, 2024 15:22
norascheuch
norascheuch approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✨

@charisk charisk merged commit 6d8de1b into main Apr 8, 2024
15 checks passed
@charisk charisk deleted the charisk/do-not-mock-modeling-events branch April 8, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norascheuch norascheuch norascheuch approved these changes

@koesie10 koesie10 koesie10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charisk @koesie10 @norascheuch