Skip to content

Commit

Permalink
fix: mono log comparison view start
Browse files Browse the repository at this point in the history
  • Loading branch information
esbena committed Nov 15, 2024
1 parent 73b6605 commit 3a09f18
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions extensions/ql-vscode/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1225,9 +1225,14 @@ async function showPerformanceComparison(
const fromLog = from?.evalutorLogPaths?.jsonSummary;
const toLog = to.evalutorLogPaths?.jsonSummary;

if (fromLog === undefined || toLog === undefined) {
if (from && fromLog === undefined) {
return extLogger.showWarningMessage(
`Cannot compare performance as the structured logs are missing. Did they queries complete normally?`,
`Cannot compare performance as the "from" structured logs are missing. Did they queries complete normally?`,
);
}
if (toLog === undefined) {
return extLogger.showWarningMessage(
`Cannot compare performance as the "to" structured logs are missing. Did they queries complete normally?`,
);
}
if (from) {
Expand Down

0 comments on commit 3a09f18

Please sign in to comment.