Verify token set #31
Merged
Verify token set #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to make the example a little more interesting, I acidentally used an invalid token set: one token would not re-encode to itself. This adds a verification step after BPE construction to explicitly prevent this, instead of just getting strange results. Since BPE construction is expensive already, I don't think this extra step is a problem. (And it doesn't happen when loading a serialized instance!)
I was looking at the example to have it include multiple merge steps, instead of just two-byte pairs. I still need to update the README to show what it looks like now.