Merge pull request #983 from github-for-unity/copyhelper-fixes

Fixing the logging of CopyHelper
github-for-unity · Dec 12, 2018 · 1cfcaad · 1cfcaad · serkonda7 · Jan 2, 2019
2 parents 9ada287 + 239d643
commit 1cfcaad
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/GitHub.Api/Installer/CopyHelper.cs b/src/GitHub.Api/Installer/CopyHelper.cs
@@ -12,7 +12,7 @@ public static class CopyHelper
 
         public static void Copy(NPath fromPath, NPath toPath)
         {
-            Logger.Trace("Copying from " + fromPath + " to " + toPath + ".");
+            Logger.Trace("Copying from {0} to {1}", fromPath, toPath);
 
             try
             {
@@ -28,7 +28,7 @@ public static void Copy(NPath fromPath, NPath toPath)
                 }
                 catch (Exception ex2)
                 {
-                    Logger.Error(ex1, "Error copying contents.");
+                    Logger.Error(ex2, "Error copying contents.");
                     throw;
                 }
             }
@@ -39,15 +39,15 @@ public static void Copy(NPath fromPath, NPath toPath)
         }
         public static void CopyFolder(NPath fromPath, NPath toPath)
         {
-            Logger.Trace("CopyFolder fromPath: {0} toPath:{1}", fromPath.ToString(), toPath.ToString());
+            Logger.Trace("CopyFolder from {0} to {1}", fromPath, toPath);
             toPath.DeleteIfExists();
             toPath.EnsureParentDirectoryExists();
             fromPath.Move(toPath);
         }
 
         public static void CopyFolderContents(NPath fromPath, NPath toPath)
         {
-            Logger.Trace("CopyFolder Contents fromPath: {0} toPath:{1}", fromPath.ToString(), toPath.ToString());
+            Logger.Trace("CopyFolderContents from {0} to {1}", fromPath, toPath);
             toPath.DeleteContents();
             fromPath.MoveFiles(toPath, true);
         }