-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr Sink Frame Values #1625
Zarr Sink Frame Values #1625
Conversation
299dbe5
to
f8198a8
Compare
f8198a8
to
6c00eed
Compare
If you have a multi-band tile and specify a c_value, it doesn't work as expected. That is
fails, but without the And, if this is a 1 band tile, then when I try to print the metadata, it fails:
|
Another use case I was expecting to work:
|
The first two snippets you provided have been added as a pytest and fixed in c85ebf0. |
I had another example that had been failing during
My guess is that this is due to unpopulated values in some combinations. |
Currently, the metadata entries for |
Should we cast the values stored in each frame to native python |
9a8e7d1
to
1009eb1
Compare
63c5eea
to
385a9f4
Compare
385a9f4
to
db43213
Compare
…or component and tests
845e8ad
to
b3fde84
Compare
I'd like to have issues for two follow ups to this PR: |
Ensure reading non-editable zarr files the c axis, if present, has a stride of 1. PR #1625 changed this.
Ensure reading non-editable zarr files the c axis, if present, has a stride of 1. PR #1625 changed this.
Ensure reading non-editable zarr files the c axis, if present, has a stride of 1. PR #1625 changed this.
Ensure reading non-editable zarr files the c axis, if present, has a stride of 1. PR #1625 changed this.
Ensure reading non-editable zarr files the c axis, if present, has a stride of 1. PR #1625 changed this.
Ensure reading non-editable zarr files the c axis, if present, has a stride of 1. PR #1625 changed this.
Resolves #1325. This PR adds frame values to the Zarr sink, which allows a user to specify true values for each index of a frame axis. This can be done with
addTile
or by settingframeValues
directly. Additionally, the user may set a dictionary offrameUnits
to describe the units used by each frame axis and/or a list offrameAxes
to assert an ordering to the frame axes.For example:
This PR also uses the frame values in the slider labels shown in the Frame Selector component. The following video demonstrates the value labels on axis sliders for a randomly-generated image using the new Zarr sink API.
C and Z have uniform values, while T has non-uniform values. (This image was generated with the code in
testFrameValues
intest/test_sink.py
.)https://github.com/user-attachments/assets/4b41bcd3-8164-46f8-b78b-9d919cecefa0