Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prise en compte de la nouvelle colonne "diagnostic valide" #386

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

YannickPassa
Copy link
Contributor

**Carte Notion : **

Pourquoi ?

Suite a plein de choses listées ici, prise en compte de la nouvelle colonne "diagnostic valide"

Checks

  • J'ai lancé le modèle ou seed sur un dump local (si pertinent)
  • J'ai ajouté des tests à mon code Python, ou des assertions DBT sur le modèle SQL
  • J'ai documenté ce modèle voire certains de ses champs (usage métier, tableau de bord, etc)

@rsebille rsebille force-pushed the YannickPassa/new_diag_column branch from 507b666 to 368d424 Compare December 23, 2024 08:38
Copy link
Contributor

@rsebille rsebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectivement bon à savoir que c'est plus simple (pour ne pas avoir de lock step) de ne pas reprendre le même nom de colonne, le cas actuel étant totalement fortuit 😅.

@rsebille rsebille added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 3594304 Dec 23, 2024
5 checks passed
@rsebille rsebille deleted the YannickPassa/new_diag_column branch December 23, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants