Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changement pyproject #330

Closed
wants to merge 1 commit into from
Closed

Changement pyproject #330

wants to merge 1 commit into from

Conversation

YannickPassa
Copy link
Contributor

**Carte Notion : **

Pourquoi ?

Afin que le make fix fonctionne chez moi j'ai du effectuer ces changements.

Checks

  • J'ai lancé le modèle ou seed sur un dump local (si pertinent)
  • J'ai ajouté des tests à mon code Python, ou des assertions DBT sur le modèle SQL
  • J'ai documenté ce modèle voire certains de ses champs (usage métier, tableau de bord, etc)

@YannickPassa YannickPassa requested a review from rsebille July 11, 2024 09:02
@YannickPassa YannickPassa self-assigned this Jul 11, 2024
Copy link
Contributor

@rsebille rsebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avec un ruff à jour ? Car j'ai des warnings avec ta version :

❯ ruff --version
ruff 0.4.9
❯ ruff check --fix dags dbt tests
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'isort' -> 'lint.isort'
All checks passed!

Et la doc indique bien cette nouvelle clé : https://docs.astral.sh/ruff/settings/#lint_isort_combine-as-imports

@YannickPassa
Copy link
Contributor Author

ah bah oui c bon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants