Retirer le renommage de Candidat en Candidature en ligne #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On est surs que ce changement va rien casser ? |
YannickPassa
reviewed
Jun 6, 2024
| @@ -22,10 +22,7 @@ select | |||
| then 'Motif "Autre" saisi sur les emplois' | |||
| else candidatures.motif_de_refus | |||
| end as motif_de_refus, | |||
| case | |||
There was a problem hiding this comment.
Faudrait qu'on fasse ça plus proprement et qu'on récupère le truc invariable des emplois...et ensuite un seed et clic clac kodak.
Je suis pas fan de faire les choses quick and dirty surtout pour un truc qui m'a pas l'air urgent
|
@YannickPassa je serai d'avis à faire passer cette PR pour que le pb soit résolu direct (plusieurs demandes cette semaine) et on fait une v2 propre dans un second temps ? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
laurinehu
force-pushed
the
laurinehu/candidatures_en_ligne
branch
2 times, most recently
from
14e0878 to
99b7b62
Compare
laurinehu
force-pushed
the
laurinehu/candidatures_en_ligne
branch
from
99b7b62 to
5cfb420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Carte Notion : **
Pourquoi ?
Indiquer le problème que nous sommes en train de résoudre et les objectifs métiers ou techniques qui sont visés par ces changements.
Checks