Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech: affichage d'une page "Accès refusé" à la place d'une redirection moins claire #5199

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Tech: affichage d'une page "Accès refusé" à la place d'une redirection moins claire #5199

merged 1 commit into from
Dec 6, 2024

Conversation

xavfernandez
Copy link
Contributor

🤔 Pourquoi ?

Suite à la discussion de #5178 (comment) .

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@xavfernandez
auth: add check_user to replace user_passes_test
a98d627 
To explicitly return a 403 instead of silently redirecting.
@xavfernandez xavfernandez added the no-changelog Ne doit pas figurer dans le journal des changements. label Dec 4, 2024
@xavfernandez xavfernandez self-assigned this Dec 4, 2024
@xavfernandez xavfernandez mentioned this pull request Dec 4, 2024
Merged
1 task
rsebille
rsebille approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@rsebille rsebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tonial
tonial approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@xavfernandez xavfernandez added this pull request to the merge queue Dec 6, 2024
Merged via the queue into master with commit bd94ca0 Dec 6, 2024
10 checks passed
@xavfernandez xavfernandez deleted the xfernandez/check_user branch December 6, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsebille rsebille rsebille approved these changes

@tonial tonial tonial approved these changes

@francoisfreitag francoisfreitag Awaiting requested review from francoisfreitag

Assignees

@xavfernandez xavfernandez

Labels
no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xavfernandez @tonial @rsebille