Création de compte candidat : nettoyage des URLs et vues dépréciées #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenKorr
added
the
no-changelog
On Sunday the sessions were cleaned, so we are assured that there is no reference to deprecated URLs. We're deleting deprecated URLs and views related to: - CheckNir - SearchByEmail
EwenKorr
force-pushed
the
ewen/compte-candidat-clean
branch
from
2be344d to
35914c8
Compare
francoisfreitag
approved these changes
Dec 2, 2024
xavfernandez
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
🙏
Normalement tu devrais aussi pouvoir te débarrasser de
les-emplois/itou/www/job_seekers_views/views.py
Lines 204 to 206 in a41ca93
|
Oui, en effet. J'hésitais, j'avais peur que ça casse quelque chose quand la PR #5177 sera fusionnée. Même chose pour les dernières vues qui resteront, |
On Sunday the sessions were cleaned, so we are assured that there is no reference to deprecated URLs. We're deleting deprecated URLs and cleaning CreateJobSeeker* views.
EwenKorr
force-pushed
the
ewen/compte-candidat-clean
branch
from
35914c8 to
256b2b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Dans l'optique de Créer un compte candidat depuis l'espace Mes candidats, on Extrait la création de compte candidat du parcours de candidature.
Nous sommes lundi. Dans la nuit, un cron a lancé une commande pour nettoyer les sessions, on peut donc être sûr que les nouvelles sessions ne contiennent plus les URLs dépréciées. Dans cette PR, on supprime le code de :
Les autres étapes : https://www.notion.so/plateforme-inclusion/Extraire-le-parcours-de-cr-ation-de-compte-candidat-130e8fa5c35b80b9947cea2573cf90e7?pvs=4#130e8fa5c35b800b966fdd4722014657