Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracker] Petites améliorations sur siae_kind & user_kind #980

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[Tracker] Petites améliorations sur siae_kind & user_kind #980

merged 2 commits into from
Nov 21, 2023

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Nov 20, 2023

Quoi ?

Améliorations sur le tracker :

  • remplacer user_type par user_kind (pour homogénéiser, script à lancer ensuite pour cleaner complètement les user_type de la base de stats)
  • améliorer la detection des siae dans le contexte (lié à la PR Tracker : enrichir les infos des Siae #820, il y avait pas mal de stats sans user_kind)

@raphodn raphodn self-assigned this Nov 20, 2023
SebastienReuiller
SebastienReuiller approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@SebastienReuiller SebastienReuiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sympa l'amélioration. Juste un petit oubli sur l'exclusion de l'env de dev.

lemarche/utils/tracker.py Show resolved Hide resolved
@raphodn raphodn force-pushed the raphodn/tracker-improvements branch from 0c6a117 to 83c4ca9 Compare November 21, 2023 10:09
@raphodn raphodn merged commit 0235b78 into master Nov 21, 2023
4 checks passed
@raphodn raphodn deleted the raphodn/tracker-improvements branch November 21, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastienReuiller SebastienReuiller SebastienReuiller approved these changes

@madjid-asa madjid-asa Awaiting requested review from madjid-asa

Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphodn @SebastienReuiller