Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring : remplacer datetime par timezone #952

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Refactoring : remplacer datetime par timezone #952

merged 3 commits into from
Oct 26, 2023

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Oct 23, 2023

Quoi ?

Il restait quelques endroits où l'on utilisait des dates sans TZ.

Cela provoque des warning dans nos logs

RuntimeWarning: DateTimeField Tracker.date_created received a naive datetime (2023-07-25 08:59:46.973584) while time zone support is active.
RuntimeWarning: DateTimeField Tender.validated_at received a naive datetime (2023-10-23 09:09:50.640033) while time zone support is active.

@raphodn raphodn self-assigned this Oct 23, 2023
@raphodn raphodn requested a review from madjid-asa October 23, 2023 07:48
madjid-asa
madjid-asa approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@madjid-asa madjid-asa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@raphodn raphodn merged commit 4138de9 into master Oct 26, 2023
2 checks passed
@raphodn raphodn deleted the raphodn/timezone-fixes branch October 26, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madjid-asa madjid-asa madjid-asa approved these changes

Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphodn @madjid-asa