[Dépôt de besoin] Stats supplémentaires pour Metabase #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
force-pushed
the
raphodn/tender-field-stats
branch
from
4a7c039 to
23fb1de
Compare
raphodn
force-pushed
the
raphodn/tender-field-stats
branch
from
23fb1de to
55bb1e9
Compare
raphodn
changed the base branch from
master
to
raphodn/queryset-annotate-rename
raphodn
commented
Oct 25, 2023
| self.stdout_messages_info("Updating Tender count fields...") | ||
|
|
||
| # Step 1a: build the queryset | ||
| tender_queryset = Tender.objects.with_siae_stats().all() |
There was a problem hiding this comment.
il y aurait moyen d'optimiser cette requête 🤔
- seulement les besoins validés
- date de cloture pas encore passé ?
madjid-asa
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
ça me parait good, mais je ne suis pas convaincu de la solution.
Je pense qu'une solution avec des ViewDatabase c'est peut être plus adapté et maintenable. En plus on pourrait les écrire directement dans le code pour mieux maintenir les vues. (cf https://stackoverflow.com/questions/51817841/create-database-view-from-django-model)
raphodn
force-pushed
the
raphodn/tender-field-stats
branch
from
af87015 to
a1dc72a
Compare
raphodn
added a commit
that referenced
this pull request
Dec 4, 2023
raphodn
added a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite de #949
Quoi ?
Dans Metabase, on a besoin de savoir facilement pour chaque besoin :
Or ces stats sont dans
TenderSiae, et sont compliquées à calculer et afficher... On créé donc de nouveaux champs dans le modèleTender, et on les met à jour toutes les nuits.