Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiche structure] Répare l'affichage de la carte si Inbound désactivé #928

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Sep 29, 2023

Suite de #915

Quoi ?

Dans la précédente PR, les modifications ont été effectuées en prenant en compte que l'inbound serait toujours actif. Mais lorsqu'on le desactive, la carte disparait.

J'ai ré-organisé les tempates pour que

  • la carte s'affiche dans tous les cas
  • les coordonnées ne s'affiche pas si l'inbound est désactivé

Captures d'écran

Inbound parsing activé Inbound parsing désactivé
Avant image image
Après image image

@raphodn raphodn self-assigned this Sep 29, 2023
Copy link
Contributor

@madjid-asa madjid-asa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@raphodn raphodn force-pushed the raphodn/siae-detail-map-v2-without-inbound branch from b5beda0 to 2b5fc71 Compare October 2, 2023 13:12
@raphodn raphodn merged commit af09f37 into master Oct 2, 2023
4 checks passed
@raphodn raphodn deleted the raphodn/siae-detail-map-v2-without-inbound branch October 2, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants