[Recherche] Remonter les prestataires qui ont un logo #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienReuiller
approved these changes
Sep 19, 2023
| @@ -1016,35 +1016,44 @@ def test_should_order_by_last_updated(self): | |||
| self.assertEqual(siaes[0].name, "ABC Insertion") | |||
|
|
|||
| def test_should_bring_the_siae_with_users_to_the_top(self): | |||
| siae_with_user = SiaeFactory(name="ZZ ESI") | |||
| siae_with_user = SiaeFactory(name="ZZ ESI user") | |||
There was a problem hiding this comment.
Pourquoi tu ne mets pas les factories dans le setUpTestData ? Ça permettrait de vérifier que les structures avec description passent bien devant celles avec logo.
There was a problem hiding this comment.
En fait ici il y a plusieurs tests quasi identiques, où l'on créé des structures avec logo, mais aussi avec description ou avec offer ou avec user, et on s'assure qu'elle remonte au dessus.
Donc si on les créé dans le setUpTestData ca serait compliqué à tester chaque cas de figure ensuite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Dans les résultats de recherche, booster la position des prestataires qui ont un logo (on boostait déjà ceux qui avaient rempli leur prestations et leur description)